Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: Source/core/dom/DocumentLifecycleNotifier.h

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/DocumentLifecycleNotifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DocumentLifecycleNotifier.h
diff --git a/Source/core/dom/DocumentLifecycleNotifier.h b/Source/core/dom/DocumentLifecycleNotifier.h
index 229002a212b63bd1db64590e5c99ab4877f5d95b..abb78e0c11da6d67165b0e4ba70da3714e8acb50 100644
--- a/Source/core/dom/DocumentLifecycleNotifier.h
+++ b/Source/core/dom/DocumentLifecycleNotifier.h
@@ -26,18 +26,17 @@
#ifndef DocumentLifecycleNotifier_h
#define DocumentLifecycleNotifier_h
-#include "platform/LifecycleNotifier.h"
-#include "wtf/HashSet.h"
+#include "core/dom/Document.h"
+#include "core/dom/DocumentLifecycleObserver.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/TemporaryChange.h"
namespace blink {
-class Document;
-class DocumentLifecycleObserver;
-
class DocumentLifecycleNotifier : public LifecycleNotifier<Document> {
public:
+ static PassOwnPtr<DocumentLifecycleNotifier> create(Document*);
+
void notifyDocumentWasDetached();
#if !ENABLE(OILPAN)
void notifyDocumentWasDisposed();
@@ -46,14 +45,34 @@ public:
virtual void addObserver(Observer*) override final;
virtual void removeObserver(Observer*) override final;
-protected:
+private:
explicit DocumentLifecycleNotifier(Document*);
-private:
using DocumentObserverSet = HashSet<DocumentLifecycleObserver*>;
DocumentObserverSet m_documentObservers;
};
+inline PassOwnPtr<DocumentLifecycleNotifier> DocumentLifecycleNotifier::create(Document* document)
+{
+ return adoptPtr(new DocumentLifecycleNotifier(document));
+}
+
+inline void DocumentLifecycleNotifier::notifyDocumentWasDetached()
+{
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverDocumentObservers);
+ for (DocumentLifecycleObserver* observer : m_documentObservers)
+ observer->documentWasDetached();
+}
+
+#if !ENABLE(OILPAN)
+inline void DocumentLifecycleNotifier::notifyDocumentWasDisposed()
+{
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverDocumentObservers);
+ for (DocumentLifecycleObserver* observer : m_documentObservers)
+ observer->documentWasDisposed();
+}
+#endif
+
} // namespace blink
#endif // DocumentLifecycleNotifier_h
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/DocumentLifecycleNotifier.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698