Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 901663002: Revert of Add WeakKeyMap to v8.h (Closed)

Created:
5 years, 10 months ago by yurys
Modified:
5 years, 10 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add WeakKeyMap to v8.h (patchset #2 id:20001 of https://codereview.chromium.org/891473005/) Reason for revert: Revert this patch due to shared win build compilation failure http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5030/steps/compile/logs/stdio Original issue's description: > Add WeakKeyMap to v8.h > > A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. > > BUG=chromium:437416 > LOG=Y > > Committed: https://crrev.com/ee7ed39ac8327124e74dd7ad5f1de0dede988cb7 > Cr-Commit-Position: refs/heads/master@{#26425} TBR=jochen@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437416 Committed: https://crrev.com/1f7e3b3483e1cf654d4edd00a4e2dc6597020491 Cr-Commit-Position: refs/heads/master@{#26430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -275 lines) Patch
M include/v8.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime-collections.cc View 5 chunks +26 lines, -42 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -73 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
Created Revert of Add WeakKeyMap to v8.h
5 years, 10 months ago (2015-02-04 15:12:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901663002/1
5 years, 10 months ago (2015-02-04 15:12:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 15:12:47 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 15:12:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f7e3b3483e1cf654d4edd00a4e2dc6597020491
Cr-Commit-Position: refs/heads/master@{#26430}

Powered by Google App Engine
This is Rietveld 408576698