Issue 9016053: Violating type bounds on a new invocation is a static type error, not a compile error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9016053: Violating type bounds on a new invocation is a static type error, not a compile error (Closed)

Created:
8 years, 11 months ago by zundel

Modified:
8 years, 11 months ago

Reviewers:
scheglov, codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Violating type bounds on a new invocation is a static type error, not a compile error http://code.google.com/p/dart/issues/detail?id=1027 Committed: https://code.google.com/p/dart/source/detail?r=2921

Patch Set 2 : Added junit test' #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		1 chunk	+1 line, -1 line	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

codefu

LGTM + non-substantial nit. http://codereview.chromium.org/9016053/diff/2001/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right): http://codereview.chromium.org/9016053/diff/2001/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java#newcode1033 compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1033: Type type = validateTypeNode(typeNode, false); ...

8 years, 11 months ago (2012-01-03 20:43:40 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 9016053: Violating type bounds on a new invocation is a static type error, not a compile error (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added junit test' #

Messages