Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 9016036: Implement the new first run bubble, clean up old bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.h ('k') | chrome/browser/ui/omnibox/location_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
index c7a77445eae9322342a5d66ad8623c691dcdf6d6..8f42c0035b5f97649057831ca5e01470afa5bdee 100644
--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc
+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc
@@ -84,10 +84,6 @@ const int kRightMargin = 1;
// We draw a border on the top and bottom (but not on left or right).
const int kBorderThickness = 1;
-// Left margin of first run bubble.
-const int kFirstRunBubbleLeftMargin = 8;
-// Extra vertical spacing for first run bubble.
-const int kFirstRunBubbleTopMargin = 5;
// Spacing needed to align the bubble with the left side of the omnibox.
const int kFirstRunBubbleLeftSpacing = 4;
@@ -174,7 +170,7 @@ LocationBarViewGtk::LocationBarViewGtk(Browser* browser)
transition_(content::PageTransitionFromInt(
content::PAGE_TRANSITION_TYPED |
content::PAGE_TRANSITION_FROM_ADDRESS_BAR)),
- first_run_bubble_(this),
+ weak_ptr_factory_(this),
popup_window_mode_(false),
theme_service_(NULL),
hbox_width_(0),
@@ -586,14 +582,13 @@ TabContentsWrapper* LocationBarViewGtk::GetTabContentsWrapper() const {
return browser_->GetSelectedTabContentsWrapper();
}
-void LocationBarViewGtk::ShowFirstRunBubble(FirstRun::BubbleType bubble_type) {
+void LocationBarViewGtk::ShowFirstRunBubble() {
// We need the browser window to be shown before we can show the bubble, but
// we get called before that's happened.
MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&LocationBarViewGtk::ShowFirstRunBubbleInternal,
- first_run_bubble_.GetWeakPtr(),
- bubble_type));
+ weak_ptr_factory_.GetWeakPtr()));
}
void LocationBarViewGtk::SetSuggestedText(const string16& text,
@@ -1022,16 +1017,13 @@ void LocationBarViewGtk::SetKeywordHintLabel(const string16& keyword) {
trailing.c_str());
}
-void LocationBarViewGtk::ShowFirstRunBubbleInternal(
- FirstRun::BubbleType bubble_type) {
+void LocationBarViewGtk::ShowFirstRunBubbleInternal() {
if (!location_entry_.get() || !widget()->window)
return;
gfx::Rect bounds = gtk_util::WidgetBounds(location_icon_image_);
bounds.set_x(bounds.x() + kFirstRunBubbleLeftSpacing);
-
- FirstRunBubble::Show(browser_->profile(), location_icon_image_, bounds,
- bubble_type);
+ FirstRunBubble::Show(browser_->profile(), location_icon_image_, bounds);
}
gboolean LocationBarViewGtk::OnIconReleased(GtkWidget* sender,
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.h ('k') | chrome/browser/ui/omnibox/location_bar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698