Implement the new first run bubble, clean up old bubbles.

Implement the new first run bubble, clean up old bubbles.
Remove large/minimal/oem bubble types, use a single bubble.
Update strings, remove unused code, add Change link/button.
Point Change link to chrome://settings/searchEngines for now.

Old string: "Search using Google from right here"
New string: "You can search from here with Google!"
New link/button text: "Change"
Mac xib changes: Add 'Change' button, widen bubble to fit.

BUG=107005
TEST=First run search engine bubble now says "You can search from here with Google!"
TBR=pkasting

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117521

[msw, 2012-01-10 21:52:25]

Please review; thanks! (before/after pics on the bug)
Elliot: chrome/browser/ui/gtk/*
Nico: chrome/browser/ui/cocoa/* and chrome/app/nibs/FirstRunBubble.xib
Miranda: Everything else :)

[Elliot Glaysher, 2012-01-10 22:12:59]

gtk lgtm

[Nico, 2012-01-10 22:18:29]

cocoa bits lgtm

Please add a "xib changes: Moved button foo 4 px to the left" (except with a
real description.)

I'd move all these "change" links / buttons so that their baselines align with
the heading baseline.

[Miranda Callahan, 2012-01-10 22:25:47]

Other bits LGTM with nits.

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
File chrome/browser/ui/cocoa/first_run_bubble_controller.h (right):

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
chrome/browser/ui/cocoa/first_run_bubble_controller.h:23: -
(IBAction)onChange:(id)sender;
nit: Please add a comment indicating exactly what change you mean here.

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
File chrome/browser/ui/cocoa/first_run_bubble_controller.mm (right):

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:9: #include
"chrome/browser/ui/browser_list.h"
nit: alphaordering

[msw, 2012-01-11 00:27:10]

Done; also updated Win and Mac spacing per bug feedback.

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
File chrome/browser/ui/cocoa/first_run_bubble_controller.h (right):

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
chrome/browser/ui/cocoa/first_run_bubble_controller.h:23: -
(IBAction)onChange:(id)sender;
On 2012/01/10 22:25:47, Miranda Callahan wrote:
> nit: Please add a comment indicating exactly what change you mean here.

Done.

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
File chrome/browser/ui/cocoa/first_run_bubble_controller.mm (right):

http://codereview.chromium.org/9016036/diff/23046/chrome/browser/ui/cocoa/fir...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:9: #include
"chrome/browser/ui/browser_list.h"
On 2012/01/10 22:25:47, Miranda Callahan wrote:
> nit: alphaordering

Done.

[commit-bot: I haz the power, 2012-01-11 21:38:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9016036/33001

[commit-bot: I haz the power, 2012-01-11 21:38:51]

Can't apply patch for file chrome/browser/first_run/first_run.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/first_run/first_run.cc
Hunk #3 FAILED at 395.
Hunk #4 FAILED at 579.
2 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/first_run/first_run.cc.rej

[commit-bot: I haz the power, 2012-01-12 03:18:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9016036/40033

[commit-bot: I haz the power, 2012-01-12 03:18:50]

Presubmit check for 9016036-40033 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/views/location_bar/location_bar_view.cc,chrome/browser/ui/views/location_bar/location_bar_view.h,chrome/browser/ui/views/first_run_bubble.h,chrome/browser/ui/browser.cc,chrome/browser/ui/views/first_run_bubble_unittest.cc,chrome/browser/ui/omnibox/location_bar.h,chrome/browser/ui/views/first_run_bubble.cc

Presubmit checks took 2.6s to calculate.

[msw, 2012-01-12 03:34:36]

+Ben for OWNERS. PTAL; thanks!

[Ben Goodger (Google), 2012-01-12 16:12:35]

lgtm

[commit-bot: I haz the power, 2012-01-12 18:06:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9016036/40033

[commit-bot: I haz the power, 2012-01-12 18:06:49]

Presubmit check for 9016036-40033 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/ui/omnibox/location_bar.h

Presubmit checks took 3.6s to calculate.

[msw, 2012-01-12 18:34:58]

+Peter for chrome/browser/ui/omnibox/location_bar.h OWNERS. PTAL; thanks!

[commit-bot: I haz the power, 2012-01-12 20:06:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9016036/40033

[Peter Kasting, 2012-01-12 20:41:42]

OWNERS LGTM

[commit-bot: I haz the power, 2012-01-12 21:52:44]

Change committed as 117521