Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: src/core/SkBlitRow_D16.cpp

Issue 901593002: Remove opaque versions of Color32_D565 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Modified to remove opaque functions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/opts/SkBlitRow_opts_arm.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkBlitRow_D16.cpp
diff --git a/src/core/SkBlitRow_D16.cpp b/src/core/SkBlitRow_D16.cpp
index 6bf4cea9974f5d4488a65bd6aec532ccbe8096e5..d5082769c53ae5b5a4a84d5467343dec64839bcf 100644
--- a/src/core/SkBlitRow_D16.cpp
+++ b/src/core/SkBlitRow_D16.cpp
@@ -255,14 +255,10 @@ SkBlitRow::Proc16 SkBlitRow::Factory16(unsigned flags) {
static const SkBlitRow::ColorProc16 gDefault_565_ColorProcs[] = {
#if 0
- Color32_D565,
Color32A_D565,
- Color32_D565_Dither,
Color32A_D565_Dither
#else
- // TODO: stop cheating and fill in the above specializations!
- Color32A_D565,
- Color32A_D565,
+ // TODO: stop cheating and fill dither from the above specializations!
Color32A_D565,
Color32A_D565,
#endif
@@ -272,8 +268,9 @@ SkBlitRow::ColorProc16 SkBlitRow::ColorFactory16(unsigned flags) {
SkASSERT((flags & ~kFlags16_Mask) == 0);
// just so we don't crash
flags &= kFlags16_Mask;
- // we ignore kGlobalAlpha_Flag, so shift down
- flags >>= 1;
+ // we ignore both kGlobalAlpha_Flag and kSrcPixelAlpha_Flag, so shift down
+ // since this factory is only used for transparent source alphas
+ flags >>= 2;
SkASSERT(flags < SK_ARRAY_COUNT(gDefault_565_ColorProcs));
« no previous file with comments | « no previous file | src/opts/SkBlitRow_opts_arm.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698