Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 9015015: Take advantage of the new Pass() machinery on scoped_ptr{,_malloc}. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/web_data_source_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index d2ec3be64d55e7c7ade1eb969f8a9b77d337e10d..c9aa47fadbcad00cf60cf8693d3c9db639a86b71 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -197,26 +197,28 @@ bool WebMediaPlayerImpl::Initialize(
new media::CompositeDataSourceFactory());
if (use_simple_data_source) {
- data_source_factory->AddFactory(simple_data_source_factory.release());
- data_source_factory->AddFactory(buffered_data_source_factory.release());
+ data_source_factory->AddFactory(simple_data_source_factory.Pass());
+ data_source_factory->AddFactory(buffered_data_source_factory.Pass());
} else {
- data_source_factory->AddFactory(buffered_data_source_factory.release());
- data_source_factory->AddFactory(simple_data_source_factory.release());
+ data_source_factory->AddFactory(buffered_data_source_factory.Pass());
+ data_source_factory->AddFactory(simple_data_source_factory.Pass());
}
scoped_ptr<media::DemuxerFactory> demuxer_factory(
- new media::FFmpegDemuxerFactory(data_source_factory.release(),
- pipeline_message_loop));
+ // TODO(fischman): replace the extra scoped_ptr+release() with Pass() when
+ // http://crbug.com/109026 is fixed.
+ new media::FFmpegDemuxerFactory(scoped_ptr<media::DataSourceFactory>(
+ data_source_factory.release()), pipeline_message_loop));
std::string source_url = GetClient()->sourceURL().spec();
if (!source_url.empty()) {
demuxer_factory.reset(
new media::ChunkDemuxerFactory(source_url,
- demuxer_factory.release(),
+ demuxer_factory.Pass(),
proxy_));
}
- filter_collection_->SetDemuxerFactory(demuxer_factory.release());
+ filter_collection_->SetDemuxerFactory(demuxer_factory.Pass());
// Add in the default filter factories.
filter_collection_->AddAudioDecoder(new media::FFmpegAudioDecoder(
@@ -301,8 +303,8 @@ void WebMediaPlayerImpl::load(const WebKit::WebURL& url) {
// that the MediaStream represents a local webcam. This will need to
// change in the future when GetVideoDecoder is no longer hardcoded to
// only return CaptureVideoDecoders.
- filter_collection_->SetDemuxerFactory(
- new media::DummyDemuxerFactory(has_video, has_audio, true));
+ filter_collection_->SetDemuxerFactory(scoped_ptr<media::DemuxerFactory>(
+ new media::DummyDemuxerFactory(has_video, has_audio, true)));
}
}
@@ -315,7 +317,7 @@ void WebMediaPlayerImpl::load(const WebKit::WebURL& url) {
SetNetworkState(WebKit::WebMediaPlayer::Loading);
SetReadyState(WebKit::WebMediaPlayer::HaveNothing);
pipeline_->Start(
- filter_collection_.release(),
+ filter_collection_.Pass(),
url.spec(),
base::Bind(&WebMediaPlayerProxy::PipelineInitializationCallback,
proxy_.get()));
« no previous file with comments | « webkit/media/web_data_source_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698