Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 901493006: [NaCl SDK] Update sdktools to include proxy fix to fancy_urllib. (Closed)

Created:
5 years, 10 months ago by binji
Modified:
5 years, 10 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update sdktools to include proxy fix to fancy_urllib. This includes commit 6d97ebd: Update fancy_urllib to more recent version. This includes a fix for Python 2.7.7, which removed the HTTPSConnection._set_hostport function. BUG=410545 R=sbc@chromium.org Committed: https://crrev.com/0ff80d9523eafa632a7c5cfaf3a366573c70efe5 Cr-Commit-Position: refs/heads/master@{#314938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest0.json View 1 chunk +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 10 months ago (2015-02-05 22:14:54 UTC) #1
Sam Clegg
lgtm
5 years, 10 months ago (2015-02-05 23:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901493006/1
5 years, 10 months ago (2015-02-06 00:49:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 01:21:22 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:22:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ff80d9523eafa632a7c5cfaf3a366573c70efe5
Cr-Commit-Position: refs/heads/master@{#314938}

Powered by Google App Engine
This is Rietveld 408576698