Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 901493003: Extract some account chooser views things for cross-platform use. (Closed)

Created:
5 years, 10 months ago by dconnelly
Modified:
5 years, 10 months ago
Reviewers:
vasilii, Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract some account chooser views things for cross-platform use. - AvatarFetcher moves out as AccountAvatarFetcher - Avatar icon size constant moves out as kAvatarImageSize - Avatar icon scaling moves out as ScaleImageForAccountAvatar BUG=448011 Committed: https://crrev.com/bcfc1b3cc8e59d4be12a4317ec95fbc97460a00c Cr-Commit-Position: refs/heads/master@{#315316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -79 lines) Patch
A chrome/browser/ui/passwords/account_avatar_fetcher.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/ui/passwords/account_avatar_fetcher.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.h View 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 6 chunks +8 lines, -73 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dconnelly
5 years, 10 months ago (2015-02-06 09:25:27 UTC) #4
dconnelly
5 years, 10 months ago (2015-02-06 16:15:04 UTC) #6
Mike West
LGTM.
5 years, 10 months ago (2015-02-06 17:06:17 UTC) #7
vasilii
lgtm
5 years, 10 months ago (2015-02-06 17:15:42 UTC) #8
dconnelly
On 2015/02/06 17:15:42, vasilii wrote: > lgtm You guys are awesome reviewers.
5 years, 10 months ago (2015-02-09 14:53:11 UTC) #10
dconnelly
On 2015/02/09 14:53:11, dconnelly wrote: > On 2015/02/06 17:15:42, vasilii wrote: > > lgtm > ...
5 years, 10 months ago (2015-02-09 14:53:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901493003/40001
5 years, 10 months ago (2015-02-09 14:53:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-02-09 16:13:17 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:13:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcfc1b3cc8e59d4be12a4317ec95fbc97460a00c
Cr-Commit-Position: refs/heads/master@{#315316}

Powered by Google App Engine
This is Rietveld 408576698