Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 901463004: MachOImageSymbolTableReader: permit indirect symbols to exist among external defined symbols (Closed)

Created:
5 years, 10 months ago by Mark Mentovai
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

MachOImageSymbolTableReader: permit indirect symbols to exist among external defined symbols. Indirect symbols remain unsupported. Xcode 5.1 ld64-236.3/src/ld/LinkEditClassic.hpp ld::tool::SymbolTableAtom<>::addGlobal() is responsible for producing symbols found in the extdef portion of the symbol table. It always sets the type to N_ABS, N_SECT, or N_INDR, each with the N_EXT bit set. The N_PEXT bit is never set for non-object files, and we’re not concerned with reading object files. With this change to tolerate N_INDR, I think we’re covering all of the symbol types that we might find ld writing to the extdef portion of the symbol table. https://groups.google.com/a/chromium.org/forum/#!topic/crashpad-dev/k7QkLwO71Zo R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/878400947fee0b0f5398ea38e7f5e7dfd330b109

Patch Set 1 #

Patch Set 2 : Be more positive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -48 lines) Patch
M snapshot/mac/mach_o_image_reader_test.cc View 1 1 chunk +1 line, -7 lines 0 comments Download
M snapshot/mac/mach_o_image_symbol_table_reader.cc View 1 1 chunk +57 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 10 months ago (2015-02-04 23:37:24 UTC) #2
Robert Sesek
LGTM
5 years, 10 months ago (2015-02-05 17:37:43 UTC) #3
Mark Mentovai
5 years, 10 months ago (2015-02-05 18:39:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
878400947fee0b0f5398ea38e7f5e7dfd330b109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698