Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 901453002: Add comment for the forked Dart revision for the assembler code. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add comment for the forked Dart revision for the assembler code. Also note to keep that up to date. See also Patch set 1 of https://codereview.chromium.org/574133002/, vs later patch sets. Some things that were changed: (*) Headers / constants use Ice version (RegX8632::Encoded_Reg_eax vs EAX), (KB / MB -> other...) (*) Use llvm/Subzero allocator instead of Dart one. (*) Class/Field/On-stack-replacement/Dart runtime stuff is removed (*) Relocation/Fixups are now POD -- rather than a class with a virtual method for fixup. For now, we write out an ELF relocation, but later we may do a target pass to handle function calls within the same section, etc. (*) ASSERT -> assert (*) uword -> uintptr_t (should check). (*) clang-format (*) ??? BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=33a5f41d1e1224bdc8dab1fd1f2834281331df40

Patch Set 1 #

Total comments: 2

Patch Set 2 : add a link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/assembler.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-03 21:34:14 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/901453002/diff/1/src/assembler.cpp File src/assembler.cpp (right): https://codereview.chromium.org/901453002/diff/1/src/assembler.cpp#newcode8 src/assembler.cpp:8: // This is forked from Dart revision 39313. ...
5 years, 10 months ago (2015-02-03 21:44:50 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/901453002/diff/1/src/assembler.cpp File src/assembler.cpp (right): https://codereview.chromium.org/901453002/diff/1/src/assembler.cpp#newcode8 src/assembler.cpp:8: // This is forked from Dart revision 39313. On ...
5 years, 10 months ago (2015-02-03 23:09:09 UTC) #5
jvoung (off chromium)
5 years, 10 months ago (2015-02-04 00:06:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
33a5f41d1e1224bdc8dab1fd1f2834281331df40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698