Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 901323004: Pass source device to window.eventSender.gestureFlingStart. (Closed)

Created:
5 years, 10 months ago by tdresser
Modified:
5 years, 10 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pass source device to window.eventSender.gestureFlingStart. This is the second of three patches. The first is: https://codereview.chromium.org/902173003 The third patch (in chrome) will change EventSenderBindings::GestureFlingStart to require a source device. BUG=456136 TEST=LayoutTests/fast/events/touch/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190161

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M LayoutTests/fast/events/touch/gesture/gesture-scrollbar-fling.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/pad-gesture-cancel.html View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/pad-gesture-fling.js View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html View 4 chunks +8 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Rick Byers
https://codereview.chromium.org/901323004/diff/1/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html File LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html (right): https://codereview.chromium.org/901323004/diff/1/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html#newcode66 LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html:66: "touchpad"); this test is in the touchscreen directly - ...
5 years, 10 months ago (2015-02-07 11:22:47 UTC) #2
tdresser
https://codereview.chromium.org/901323004/diff/1/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html File LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html (right): https://codereview.chromium.org/901323004/diff/1/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html#newcode66 LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html:66: "touchpad"); On 2015/02/07 11:22:47, Rick Byers wrote: > this ...
5 years, 10 months ago (2015-02-09 13:56:51 UTC) #3
Rick Byers
On 2015/02/09 13:56:51, tdresser wrote: > https://codereview.chromium.org/901323004/diff/1/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html > File > LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html > (right): > > ...
5 years, 10 months ago (2015-02-11 07:03:37 UTC) #4
Rick Byers
lgtm
5 years, 10 months ago (2015-02-11 07:04:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901323004/1
5 years, 10 months ago (2015-02-13 17:36:39 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 18:52:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190161

Powered by Google App Engine
This is Rietveld 408576698