Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 901313002: Fix build of pdfium_diff (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build of pdfium_diff Commit af18cb3 didn't build standalone. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dbe2a8e6ac3d92edf640ed10a6d4a0e658bc35c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M samples/image_diff_png.h View 1 chunk +2 lines, -0 lines 0 comments Download
M samples/samples.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Argh, looks like I missed a step while testing that the previous CL builds locally.
5 years, 10 months ago (2015-02-05 23:21:10 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as dbe2a8e6ac3d92edf640ed10a6d4a0e658bc35c5 (presubmit successful).
5 years, 10 months ago (2015-02-05 23:21:22 UTC) #3
Lei Zhang
5 years, 10 months ago (2015-02-05 23:28:38 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698