Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 901273002: libxml2: Add missing dependency on libm (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libxml2: Add missing dependency on libm The library uses functions from "math.h". This fixes the embedded build with -Wl,-z,defs. BUG=445627 TEST=linux_ecs_ozone tryjob TBR=cpu Committed: https://crrev.com/e1393cf52aa9e7b8cbcf0a4776030253e8de2583 Cr-Commit-Position: refs/heads/master@{#314906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/libxml/libxml.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 10 months ago (2015-02-05 21:21:54 UTC) #2
dnicoara
lgtm
5 years, 10 months ago (2015-02-05 21:22:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901273002/1
5 years, 10 months ago (2015-02-05 22:05:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 23:10:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:11:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1393cf52aa9e7b8cbcf0a4776030253e8de2583
Cr-Commit-Position: refs/heads/master@{#314906}

Powered by Google App Engine
This is Rietveld 408576698