Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2255)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 901253002: move relevance computation from client to server (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index edbdd8ee9f525da1033be51c0c93f274d9d12e96..6237e5cd200485793e25f2f42b3f49c179514a09 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -111,7 +111,8 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder implements
/**
* Add imported element suggestions.
*/
- void _addElementSuggestions(List<Element> elements) {
+ void _addElementSuggestions(List<Element> elements, {int relevance:
+ COMPLETION_RELEVANCE_DEFAULT}) {
elements.forEach((Element elem) {
if (elem is! ClassElement) {
if (typesOnly) {
@@ -126,7 +127,7 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder implements
}
}
}
- addSuggestion(elem);
+ addSuggestion(elem, relevance: relevance);
});
}
@@ -149,14 +150,26 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder implements
String name = inheritedTypes.removeLast();
ClassElement elem = cache.importedClassMap[name];
if (visited.add(name) && elem != null) {
- _addElementSuggestions(elem.fields);
- _addElementSuggestions(elem.accessors);
- _addElementSuggestions(elem.methods);
+ _addElementSuggestions(
+ elem.fields,
+ relevance: DART_RELEVANCE_INHERITED_FIELD);
+ _addElementSuggestions(
+ elem.accessors,
+ relevance: DART_RELEVANCE_INHERITED_ACCESSOR);
+ _addElementSuggestions(
+ elem.methods,
+ relevance: DART_RELEVANCE_INHERITED_METHOD);
elem.allSupertypes.forEach((InterfaceType type) {
if (visited.add(type.name) && type.element != null) {
- _addElementSuggestions(type.element.fields);
- _addElementSuggestions(type.element.accessors);
- _addElementSuggestions(type.element.methods);
+ _addElementSuggestions(
+ type.element.fields,
+ relevance: DART_RELEVANCE_INHERITED_FIELD);
+ _addElementSuggestions(
+ type.element.accessors,
+ relevance: DART_RELEVANCE_INHERITED_ACCESSOR);
+ _addElementSuggestions(
+ type.element.methods,
+ relevance: DART_RELEVANCE_INHERITED_METHOD);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698