Issue 901243002: Fix and IPC fuzzer top crasher in OnWorkerScriptLoaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 901243002: Fix and IPC fuzzer top crasher in OnWorkerScriptLoaded. (Closed)

Created:
5 years, 10 months ago by Martin Barbella

Modified:
5 years, 10 months ago

Reviewers:
falken, nhiroki

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, inferno

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix and IPC fuzzer top crasher in OnWorkerScriptLoaded. A compromised renderer can pass an arbitrary |provider_id|, so we should ensure that |provider_host| is not NULL and remove the DCHECK. See https://cluster-fuzz.appspot.com/testcase?key=4713217552023552 R=falken@chromium.org,nhiroki@chromium.org Committed: https://crrev.com/d35d0fb116bdbc3c249c1a4560562fb1678e3416 Cr-Commit-Position: refs/heads/master@{#314881}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/browser/service_worker/service_worker_dispatcher_host.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901243002/1

5 years, 10 months ago (2015-02-05 18:58:44 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-05 21:32:07 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d35d0fb116bdbc3c249c1a4560562fb1678e3416
Cr-Commit-Position: refs/heads/master@{#314881}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages