Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 901233003: Enable Cloud Import feature by default. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
satorux1, Ilya Sherman
CC:
chromium-reviews, oshima+watch_chromium.org, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, asvitkine+watch_chromium.org, stevenjb+watch_chromium.org, bengold
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Cloud Import feature by default. BUG=420680 TEST=browser_test: FileManagerJsTest.* TBR=cpu@chromium.org for .grd changes. Committed: https://crrev.com/ad90351f940b2ff53df05700c1aa9081b6858e1f Cr-Commit-Position: refs/heads/master@{#315415}

Patch Set 1 #

Patch Set 2 : Update histogram value. #

Total comments: 1

Patch Set 3 : Respond to review comments. #

Patch Set 4 : Don't check history for ineligible files...ensuring history is not loaded unnecessarily. #

Patch Set 5 : Merge w/ master. #

Patch Set 6 : Update device handler test to use new flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler_unittest.js View 1 2 3 4 5 4 chunks +4 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/common/js/importer_common.js View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (10 generated)
Steve McKay
Ilya, I just pulled a number out of the air for the new histogram entry, ...
5 years, 10 months ago (2015-02-05 22:51:07 UTC) #2
Steve McKay
5 years, 10 months ago (2015-02-05 22:51:27 UTC) #3
Ilya Sherman
On 2015/02/05 22:51:07, Steve McKay wrote: > Ilya, I just pulled a number out of ...
5 years, 10 months ago (2015-02-06 00:16:39 UTC) #4
Ilya Sherman
On 2015/02/06 00:16:39, Ilya Sherman wrote: > On 2015/02/05 22:51:07, Steve McKay wrote: > > ...
5 years, 10 months ago (2015-02-06 00:16:57 UTC) #5
satorux1
chromeos LGTM with a fix: https://codereview.chromium.org/901233003/diff/20001/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/901233003/diff/20001/chromeos/chromeos_switches.cc#newcode56 chromeos/chromeos_switches.cc:56: // Enables cloud backup ...
5 years, 10 months ago (2015-02-06 01:26:06 UTC) #7
Steve McKay
Respond to review comments.
5 years, 10 months ago (2015-02-06 01:31:27 UTC) #9
satorux1
other files also lgtom
5 years, 10 months ago (2015-02-06 01:36:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901233003/40001
5 years, 10 months ago (2015-02-06 01:37:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/22201)
5 years, 10 months ago (2015-02-06 03:17:33 UTC) #14
Steve McKay
Don't check history for ineligible files...ensuring history is not loaded unnecessarily.
5 years, 10 months ago (2015-02-09 18:16:59 UTC) #15
Steve McKay
Don't check history for ineligible files...ensuring history is not loaded unnecessarily.
5 years, 10 months ago (2015-02-09 18:21:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901233003/80001
5 years, 10 months ago (2015-02-09 18:23:10 UTC) #19
Steve McKay
On 2015/02/09 18:21:58, Steve McKay wrote: > Don't check history for ineligible files...ensuring history is ...
5 years, 10 months ago (2015-02-09 18:24:17 UTC) #20
Steve McKay
Merge w/ master.
5 years, 10 months ago (2015-02-09 18:26:12 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901233003/100001
5 years, 10 months ago (2015-02-09 18:26:39 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/22967)
5 years, 10 months ago (2015-02-09 19:59:10 UTC) #25
Steve McKay
Update test to use new flag.
5 years, 10 months ago (2015-02-09 20:24:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901233003/120001
5 years, 10 months ago (2015-02-09 20:26:41 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 10 months ago (2015-02-09 22:40:44 UTC) #29
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:42:28 UTC) #30
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ad90351f940b2ff53df05700c1aa9081b6858e1f
Cr-Commit-Position: refs/heads/master@{#315415}

Powered by Google App Engine
This is Rietveld 408576698