Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4028)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api.cc

Issue 901213003: Removing the project ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/copresence/copresence_api.cc
diff --git a/chrome/browser/extensions/api/copresence/copresence_api.cc b/chrome/browser/extensions/api/copresence/copresence_api.cc
index c299df303ca566b1e71054710120e1f5b902d727..b729520d2e5779c77cc6a21c3d4930e54d4076bd 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api.cc
+++ b/chrome/browser/extensions/api/copresence/copresence_api.cc
@@ -185,19 +185,24 @@ const std::string CopresenceService::GetPlatformVersionString() const {
const std::string
CopresenceService::GetAPIKey(const std::string& app_id) const {
- // This won't be const if we use map[]
+ // Check first if the app has set its key via the API.
const auto& key = api_keys_by_app_.find(app_id);
- return key == api_keys_by_app_.end() ? std::string() : key->second;
-}
+ if (key != api_keys_by_app_.end())
+ return key->second;
+
+ // If no key was found, look in the manifest.
+ if (!app_id.empty()) {
+ const Extension* extension = ExtensionRegistry::Get(browser_context_)
+ ->GetExtensionById(app_id, ExtensionRegistry::ENABLED);
+ DCHECK(extension) << "Invalid extension ID";
+ CopresenceManifestData* manifest_data =
+ static_cast<CopresenceManifestData*>(
+ extension->GetManifestData(manifest_keys::kCopresence));
+ if (manifest_data)
+ return manifest_data->api_key;
+ }
-const std::string
-CopresenceService::GetProjectId(const std::string& app_id) const {
- const Extension* extension = ExtensionRegistry::Get(browser_context_)
- ->GetExtensionById(app_id, ExtensionRegistry::ENABLED);
- DCHECK(extension) << "Invalid extension ID";
- CopresenceManifestData* manifest_data = static_cast<CopresenceManifestData*>(
- extension->GetManifestData(manifest_keys::kCopresence));
- return manifest_data ? manifest_data->project_id : std::string();
+ return std::string();
}
copresence::WhispernetClient* CopresenceService::GetWhispernetClient() {
@@ -282,6 +287,9 @@ ExtensionFunction::ResponseAction CopresenceSetApiKeyFunction::Run() {
api::copresence::SetApiKey::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
+ LOG(WARNING) << "copresence.setApiKey() is deprecated. "
+ << "Put the key in the manifest at copresence.api_key instead.";
+
// The api key may be set to empty, to clear it.
CopresenceService::GetFactoryInstance()->Get(browser_context())
->set_api_key(extension_id(), params->api_key);

Powered by Google App Engine
This is Rietveld 408576698