Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 901213003: Removing the project ID (Closed)

Created:
5 years, 10 months ago by Charlie
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The project ID isn't needed, since it's actually ok to expose the API key. We should offer the option of putting it in the manifest though. BUG=454887 Committed: https://crrev.com/13c2644be4b4c19f8f176c2b304e53f7b1817442 Cr-Commit-Position: refs/heads/master@{#315413}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_api.cc View 1 2 3 2 chunks +19 lines, -11 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/copresence_manifest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/copresence_manifest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/copresence/proto/data.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/copresence/public/copresence_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/copresence/rpc/rpc_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 1 2 5 chunks +15 lines, -18 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/common/manifest_constants.h View 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_constants.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Charlie
It turns out we're not using the project ID after all. We'll stick with the ...
5 years, 10 months ago (2015-02-05 22:00:58 UTC) #2
Charlie
R += xiyuan
5 years, 10 months ago (2015-02-06 18:00:46 UTC) #4
Charlie
On 2015/02/06 18:00:46, Charlie wrote: > R += xiyuan Ping? This is a pretty simple ...
5 years, 10 months ago (2015-02-09 21:04:25 UTC) #5
Ken Rockot(use gerrit already)
On 2015/02/09 21:04:25, Charlie wrote: > On 2015/02/06 18:00:46, Charlie wrote: > > R += ...
5 years, 10 months ago (2015-02-09 21:06:28 UTC) #6
xiyuan
Rahul, please help review copresence changes since you are more closely involved with the work. ...
5 years, 10 months ago (2015-02-09 21:16:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901213003/60001
5 years, 10 months ago (2015-02-09 21:22:17 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-09 22:37:54 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:38:24 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/13c2644be4b4c19f8f176c2b304e53f7b1817442
Cr-Commit-Position: refs/heads/master@{#315413}

Powered by Google App Engine
This is Rietveld 408576698