Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java

Issue 901203003: Redo how AppBannerInfoBars are created and stored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving init before the early return so that restored tabs also get them Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
index f66455b1a30bfd3d3105820b24685f007d2d4b7a..297c3d74732b502de82039c391f1b106f6524880 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
@@ -7,6 +7,10 @@ package org.chromium.chrome.browser.infobar;
import android.graphics.Bitmap;
import android.widget.TextView;
+import org.chromium.base.ApplicationStatus;
+import org.chromium.base.CalledByNative;
+import org.chromium.chrome.R;
+
/**
* Infobar informing the user about an app related to this page.
*/
@@ -14,9 +18,9 @@ public class AppBannerInfoBar extends ConfirmInfoBar {
/** Web app: URL pointing to the web app. */
private final String mAppUrl;
- public AppBannerInfoBar(long nativeInfoBar, String appTitle, Bitmap iconBitmap,
- String installText, String url) {
- super(nativeInfoBar, null, 0, iconBitmap, appTitle, null, installText, null);
+ // Banner for web apps.
+ public AppBannerInfoBar(long nativeInfoBar, String appTitle, Bitmap iconBitmap, String url) {
+ super(nativeInfoBar, null, 0, iconBitmap, appTitle, null, getAddToHomescreenText(), null);
mAppUrl = url;
}
@@ -27,4 +31,14 @@ public class AppBannerInfoBar extends ConfirmInfoBar {
layout.setCustomContent(url);
super.createContent(layout);
}
+
+ private static String getAddToHomescreenText() {
+ return ApplicationStatus.getApplicationContext().getString(R.string.menu_add_to_homescreen);
+ }
+
+ @CalledByNative
+ private static InfoBar createWebAppInfoBar(
+ long nativeInfoBar, String appTitle, Bitmap iconBitmap, String url) {
+ return new AppBannerInfoBar(nativeInfoBar, appTitle, iconBitmap, url);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698