Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 901203002: Move python content handler to //services/ (Closed)

Created:
5 years, 10 months ago by etiennej
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move python content handler to //services/ zra@ mentioned that content handlers are now living under //services/. This CL moves the Python content handler to this common location. R=qsr@chromium.org, qsr BUG= Committed: https://chromium.googlesource.com/external/mojo/+/f1d4833fc9687f0d5071adbe04573b5199aef79b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -460 lines) Patch
M examples/python/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/python/content_handler/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/python/content_handler/c_base.pxd View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/python/content_handler/content_handler_main.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D mojo/python/content_handler/mojo_system_impl.pyx View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/python/content_handler/python_system_impl_helper.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/python/content_handler/python_system_impl_helper.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + services/python/content_handler/BUILD.gn View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/python/content_handler/c_base.pxd View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + services/python/content_handler/content_handler_main.cc View 1 3 chunks +15 lines, -4 lines 0 comments Download
A + services/python/content_handler/mojo_system_impl.pyx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/python/content_handler/python_system_impl_helper.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
A + services/python/content_handler/python_system_impl_helper.cc View 1 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
etiennej
5 years, 10 months ago (2015-02-05 17:02:33 UTC) #1
qsr
On 2015/02/05 17:02:33, etiennej wrote: Should this be in services/python/content_handler or service/python_content_handler The services/python seems ...
5 years, 10 months ago (2015-02-05 17:09:27 UTC) #2
etiennej
On 2015/02/05 17:09:27, qsr wrote: > On 2015/02/05 17:02:33, etiennej wrote: > > Should this ...
5 years, 10 months ago (2015-02-06 10:03:04 UTC) #3
qsr
lgtm
5 years, 10 months ago (2015-02-06 10:19:52 UTC) #4
etiennej
Committed patchset #2 (id:20001) manually as f1d4833fc9687f0d5071adbe04573b5199aef79b (presubmit successful).
5 years, 10 months ago (2015-02-06 10:35:18 UTC) #5
haltonhuo
On 2015/02/06 10:35:18, etiennej wrote: > Committed patchset #2 (id:20001) manually as > f1d4833fc9687f0d5071adbe04573b5199aef79b (presubmit ...
5 years, 10 months ago (2015-02-06 11:43:30 UTC) #6
haltonhuo
5 years, 10 months ago (2015-02-06 12:14:59 UTC) #7
Message was sent while issue was closed.
On 2015/02/06 11:43:30, haltonhuo wrote:
> On 2015/02/06 10:35:18, etiennej wrote:
> > Committed patchset #2 (id:20001) manually as
> > f1d4833fc9687f0d5071adbe04573b5199aef79b (presubmit successful).
> 
> This CL introduce android gn failure:
> $ ./mojo/tools/mojob.py  gn  --android 
> Running gn 'gen' '--check' 'out/android_Debug' '--args=is_clang=false
> use_goma=false is_asan=false is_debug=true target_arch="arm" os="android"
> mojo_use_nacl=false' ...
> ERROR at //third_party/cython/rules.gni:7:3: Assertion failed.
>   assert(is_linux)
>   ^-----
> See //services/python/content_handler/BUILD.gn:16:1: whence it was called.
> python_binary_source_set("content_handler_src") {
> ^------------------------------------------------
> 
> 
> Any idea?

Never mind, it is fixed by https://codereview.chromium.org/877593004

Powered by Google App Engine
This is Rietveld 408576698