Issue 901183003: Fix flakiness in DumpAccessibilityEvent* tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 901183003: Fix flakiness in DumpAccessibilityEvent* tests. (Closed)

Created:
5 years, 10 months ago by dmazzoni

Modified:
5 years, 10 months ago

Reviewers:
dtseng, ananta

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix flakiness in DumpAccessibilityEvent* tests. Logging revealed the flakiness was in ::AccessibleObjectFromWindow. Replace that with an alternative method, and remove the logging. BUG=440579 TBR=dtseng,ananta Committed: https://crrev.com/f137c403b6449b99d3ff49328ddc4ab729e32617 Cr-Commit-Position: refs/heads/master@{#315229}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -41 lines)			Patch
	M	content/browser/accessibility/accessibility_event_recorder_win.cc	View		6 chunks	+31 lines, -22 lines	0 comments	Download
	M	content/browser/renderer_host/legacy_render_widget_host_win.cc	View		3 chunks	+2 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901183003/1

5 years, 10 months ago (2015-02-08 07:28:16 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-08 08:13:33 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f137c403b6449b99d3ff49328ddc4ab729e32617
Cr-Commit-Position: refs/heads/master@{#315229}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages