Support deprecation warnings in shared/service workers

Source/core/workers/WorkerGlobalScope.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009, 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 316 matching lines @@
 WorkerEventQueue* WorkerGlobalScope::eventQueue() const
 {
     return m_eventQueue.get();
 }
 
 void WorkerGlobalScope::countFeature(UseCounter::Feature) const
 {
     // FIXME: How should we count features for shared/service workers?
 }
 
-void WorkerGlobalScope::countDeprecation(UseCounter::Feature) const
+void WorkerGlobalScope::countDeprecation(UseCounter::Feature feature) const
 {
     // FIXME: How should we count features for shared/service workers?
+

[sof, 2015/02/05 08:48:18]

Could you add a comment (or an assert, if you prefer) making it clear what kinds
of global scopes are handled here?

[Kunihiko Sakamoto, 2015/02/05 10:35:37]

Done.

+    // For each deprecated feature, send console message at most once
+    // per worker lifecycle.
+    if (!m_deprecationWarningBits) {
+        m_deprecationWarningBits = adoptPtr(new BitVector(UseCounter::NumberOfFeatures));
+        m_deprecationWarningBits->clearAll();
+    }
+    if (!m_deprecationWarningBits->quickGet(feature)) {
+        m_deprecationWarningBits->quickSet(feature);
+        ASSERT(!UseCounter::deprecationMessage(feature).isEmpty());
+        executionContext()->addConsoleMessage(ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, UseCounter::deprecationMessage(feature)));

[sof, 2015/02/05 08:48:18]

We know currently from calling context that executionContext() will be valid,
but could you add an assert?

[Kunihiko Sakamoto, 2015/02/05 10:35:37]

Done.

+    }
 }
 
 ConsoleMessageStorage* WorkerGlobalScope::messageStorage()
 {
     return m_messageStorage.get();
 }
 
 void WorkerGlobalScope::exceptionHandled(int exceptionId, bool isHandled)
 {
     RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = m_pendingMessages.take(exceptionId);
@@ skipping 13 matching lines @@
     visitor->trace(m_timers);
     visitor->trace(m_messageStorage);
     visitor->trace(m_pendingMessages);
     HeapSupplementable<WorkerGlobalScope>::trace(visitor);
 #endif
     ExecutionContext::trace(visitor);
     EventTargetWithInlineData::trace(visitor);
 }
 
 } // namespace blink