Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 901093003: Fix ManifestBrowserTest.Navigation to not time out --site-per-process. (Closed)

Created:
5 years, 10 months ago by alexmos
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ManifestBrowserTest.Navigation to not time out --site-per-process. See bug description for more info. BUG=455523 Committed: https://crrev.com/dd1e6a18b17c3aba5740c2f2d78cc48dd62da81c Cr-Commit-Position: refs/heads/master@{#314842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/manifest/manifest_browsertest.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
LGTM. I see this approach is already used elsewhere in the test, so let's TBR ...
5 years, 10 months ago (2015-02-05 18:30:01 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 10 months ago (2015-02-05 18:36:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901093003/1
5 years, 10 months ago (2015-02-05 18:36:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 18:43:47 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 18:44:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd1e6a18b17c3aba5740c2f2d78cc48dd62da81c
Cr-Commit-Position: refs/heads/master@{#314842}

Powered by Google App Engine
This is Rietveld 408576698