Issue 901053010: Purge AudioOutputDispatcher after close delay if no proxies exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 901053010: Purge AudioOutputDispatcher after close delay if no proxies exist. (Closed)

Created:
5 years, 10 months ago by myuan

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2292

Target Ref:
refs/pending/branch-heads/2292

Project:
chromium

Visibility:
Public.

More Reviews

Description

Purge AudioOutputDispatcher after close delay if no proxies exist. This prevents transient audio creation errors from cumulatively breaking audio output by blackholing everything to a fake audio stream after fallback attempts are exhausted. BUG=453560 TEST=new unittest, manual testing. Review URL: https://codereview.chromium.org/899923003 Cr-Commit-Position: refs/heads/master@{#314910} (cherry picked from commit c85184da42d043995203dbba777f08af00181d65) Committed: https://chromium.googlesource.com/chromium/src/+/cf90555f627b9306dada8f32168ad9b7a0bb4fa1

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -11 lines)			Patch
M	media/audio/audio_output_dispatcher_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	media/audio/audio_output_dispatcher_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	media/audio/audio_output_proxy_unittest.cc	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	media/audio/audio_output_resampler.h	View	4 chunks	+18 lines, -10 lines	0 comments	Download
M	media/audio/audio_output_resampler.cc	View	4 chunks	+34 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

myuan

5 years, 10 months ago (2015-02-05 23:45:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cf90555f627b9306dada8f32168ad9b7a0bb4fa1.

Expand Messages | Collapse Messages