Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 901053007: Document my current understanding of C++11 in Skia. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Document my current understanding of C++11 in Skia. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2fdd29d6e53d3c550bce711363a1d0d5b8069ee3

Patch Set 1 #

Patch Set 2 : mention statics #

Patch Set 3 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
A site/dev/contrib/c++11.md View 1 2 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 10 months ago (2015-02-05 18:06:15 UTC) #2
reed1
nice lgtm
5 years, 10 months ago (2015-02-05 18:36:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901053007/40001
5 years, 10 months ago (2015-02-05 18:53:32 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 18:58:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2fdd29d6e53d3c550bce711363a1d0d5b8069ee3

Powered by Google App Engine
This is Rietveld 408576698