Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 901053006: Reload frame in V8Window::namedPropertyGetterCustom after js call (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reload frame in V8Window::namedPropertyGetterCustom after js call R=marja@chromium.org BUG=454954 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
lgtm
5 years, 10 months ago (2015-02-05 15:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901053006/1
5 years, 10 months ago (2015-02-05 15:26:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189574
5 years, 10 months ago (2015-02-05 16:45:03 UTC) #5
haraken
LGTM Would you give me a permission to the bug? I want to understand a ...
5 years, 10 months ago (2015-02-05 22:28:53 UTC) #6
dcarney
5 years, 10 months ago (2015-02-06 07:49:52 UTC) #7
Message was sent while issue was closed.
I'll in the process of removing calls to GetRealNamedProperty()  in the
generated IDL code, but the generated bindings i looked at didn't have this
problem

On Thu, Feb 5, 2015 at 11:28 PM, <haraken@chromium.org> wrote:

> LGTM
>
> Would you give me a permission to the bug? I want to understand a scenario
> where
> the problem happens.
>
> Also don't we need to take care of GetRealNamedProperty() generated by the
> IDL
> compiler as well?
>
>
> https://codereview.chromium.org/901053006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698