fpdfsdk/src/fpdfview_embeddertest.cpp - Issue 901013003: Merge to XFA: Fix segv in CPDF_DataAvail::CheckRoot()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfview_embeddertest.cpp

Issue 901013003: Merge to XFA: Fix segv in CPDF_DataAvail::CheckRoot() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfview_embeddertest.cpp

diff --git a/fpdfsdk/src/fpdfview_embeddertest.cpp b/fpdfsdk/src/fpdfview_embeddertest.cpp

index 8a9020aba7e2a86230cb9233542b173845085ab3..66fbe464d0a98d0e8167e19f4fee344a252f3b23 100644

--- a/fpdfsdk/src/fpdfview_embeddertest.cpp

+++ b/fpdfsdk/src/fpdfview_embeddertest.cpp

@@ -191,3 +191,8 @@ TEST_F(FPDFViewEmbeddertest, Crasher_452455) {

FPDF_PAGE page = LoadPage(0);

EXPECT_NE(nullptr, page);

}

+TEST_F(FPDFViewEmbeddertest, Crasher_454695) {

+ // XFA branch detects this document as bad.

+ EXPECT_FALSE(OpenDocument("testing/resources/bug_454695.pdf"));