Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 901013002: Revert of Introduce ExclusiveStreamReader. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Introduce ExclusiveStreamReader. (patchset #14 id:260001 of https://codereview.chromium.org/837673002/) Reason for revert: It looks like this patch broke WebKit Linux Leaks: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/8846 Original issue's description: > Introduce ExclusiveStreamReader. > > Introduce ExclusiveStreamReader, as specified in > https://streams.spec.whatwg.org/. The implementation is behind a runtime flag. > > BUG=446121 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189417 TBR=tyoshino@chromium.org,haraken@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -1083 lines) Patch
D LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/http/tests/fetch/serviceworker/stream-reader.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/fetch/window/stream-reader.html View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/http/tests/fetch/workers/stream-reader.html View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperties.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
D Source/core/streams/ExclusiveStreamReader.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/streams/ExclusiveStreamReader.cpp View 1 chunk +0 lines, -192 lines 0 comments Download
D Source/core/streams/ExclusiveStreamReader.idl View 1 chunk +0 lines, -22 lines 0 comments Download
D Source/core/streams/ExclusiveStreamReaderTest.cpp View 1 chunk +0 lines, -433 lines 0 comments Download
M Source/core/streams/ReadableStream.h View 3 chunks +8 lines, -28 lines 0 comments Download
M Source/core/streams/ReadableStream.cpp View 10 chunks +14 lines, -104 lines 0 comments Download
M Source/core/streams/ReadableStream.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/streams/ReadableStreamImpl.h View 4 chunks +9 lines, -10 lines 0 comments Download
M Source/core/streams/ReadableStreamTest.cpp View 36 chunks +75 lines, -88 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/fetch/Body.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Introduce ExclusiveStreamReader.
5 years, 10 months ago (2015-02-04 19:48:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901013002/1
5 years, 10 months ago (2015-02-04 19:49:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189525
5 years, 10 months ago (2015-02-04 19:50:33 UTC) #3
haraken
5 years, 10 months ago (2015-02-04 22:39:00 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698