extensions: fix dev controls spacing issue.

extensions: fix dev controls spacing issue.

R=kalman@chromium.org
BUG=455196
TEST=visual

Committed: https://crrev.com/e51e9b328b6ec417250144d1636782d8033bc833
Cr-Commit-Position: refs/heads/master@{#314658}

[not at google - send to devlin, 2015-02-04 20:39:01]

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.css (right):

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.css:53: -webkit-margin-end: 5px;
I see that other WebUI buttons look fine, and don't need special treatment (or
at least they already seem to have it). Why is this code needed?

[Dan Beam, 2015-02-04 20:55:02]

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.css (right):

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.css:44: display: flex;
this collapses whitespace.  all other webui buttons aren't yet using flex, and
have whitespace inbetween them.  5px is an approximation that looks good on all
platforms/fonts (I originally added a   in the middle but didn't like
that).

[not at google - send to devlin, 2015-02-04 20:57:07]

lgtm

[not at google - send to devlin, 2015-02-04 21:01:53]

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.css (right):

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.css:44: display: flex;
On 2015/02/04 20:55:02, Dan Beam wrote:
> this collapses whitespace.  all other webui buttons aren't yet using flex, and
> have whitespace inbetween them.  5px is an approximation that looks good on
all
> platforms/fonts (I originally added a   in the middle but didn't like
> that).

I suppose even clearer would be to make the selector below

#dev-controls .button-container button:not(:last-of-type)

if it's the (#dev-controls .button-container) selector which is putting this in
the state.

concretely, in case you have like

<div id=dev-controls>
  <button>hi</button>
  <div id=button-container>
    <button>....
  </div>
</div>

which wouldn't make much sense.

[Dan Beam, 2015-02-04 21:04:21]

New patchsets have been uploaded after l-g-t-m from kalman@chromium.org

[Dan Beam, 2015-02-04 21:04:31]

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.css (right):

https://codereview.chromium.org/900993002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.css:44: display: flex;
On 2015/02/04 21:01:53, kalman wrote:
> On 2015/02/04 20:55:02, Dan Beam wrote:
> > this collapses whitespace.  all other webui buttons aren't yet using flex,
and
> > have whitespace inbetween them.  5px is an approximation that looks good on
> all
> > platforms/fonts (I originally added a   in the middle but didn't like
> > that).
> 
> I suppose even clearer would be to make the selector below
> 
> #dev-controls .button-container button:not(:last-of-type)
> 
> if it's the (#dev-controls .button-container) selector which is putting this
in
> the state.
> 
> concretely, in case you have like
> 
> <div id=dev-controls>
>   <button>hi</button>
>   <div id=button-container>
>     <button>....
>   </div>
> </div>
> 
> which wouldn't make much sense.

Done.

[Dan Beam, 2015-02-04 21:04:46]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900993002/20001

[commit-bot: I haz the power, 2015-02-04 22:23:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 22:24:28]

Patchset 2 (id:??) landed as
https://crrev.com/e51e9b328b6ec417250144d1636782d8033bc833
Cr-Commit-Position: refs/heads/master@{#314658}