Clean-up key tester.

Clean-up key tester.

This fixes a bunch of small nits:
* JSCompile is now enabled for this app.
* No need to manually focus the PNaCl plugin.
* Distinguishes between left and right modifiers for PNaCl events.
* Debug log is hidden by default, and selectable when shown.
* Minor CSS tweaks and code clean-up.

Committed: https://crrev.com/6af3ad72fa9de2b9249c788da6b54de7e045c796
Cr-Commit-Position: refs/heads/master@{#314674}

[Jamie, 2015-02-04 19:46:10]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org, lukasza@chromium.org

[Jamie, 2015-02-04 19:46:11]

Apologies for breaking my own rule and combining several unrelated things in
this CL; what started as a simple CSS cleanup ballooned into something bigger.
If you're having trouble splitting up the review, let me know and I'll send it
as a few smaller CLs.

Kelvin: for committer/OWNER and JS sanity-check.
Lukasz: since you've looked at this code recently.

https://codereview.chromium.org/900983003/diff/20001/remoting/remoting_key_te...
File remoting/remoting_key_tester.gypi (right):

https://codereview.chromium.org/900983003/diff/20001/remoting/remoting_key_te...
remoting/remoting_key_tester.gypi:58: 'webapp/js_proto/chrome_proto.js'
For JSCompile.

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/chord_tracker.js (right):

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/chord_tracker.js:124: *     string.
Left and right modifiers have the same key-code, but different "code" values, so
allowing the latter to be passed into this function makes it possible to
distinguish between them in the PNaCl case.

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/event_listeners.js (right):

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/event_listeners.js:1: /* Copyright (c) 2015
The Chromium Authors. All rights reserved.
This file is a refactoring of functionality that was previously in main.js, with
the addition of a blur handler, which makes things too complex to leave as a
mess of globals in that file.

[Łukasz Anforowicz, 2015-02-04 20:32:52]

lgtm

[kelvinp, 2015-02-04 21:13:14]

lgtm

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/event_listeners.js (right):

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/event_listeners.js:1: /* Copyright (c) 2015
The Chromium Authors. All rights reserved.
Nit: No (C).

[Jamie, 2015-02-04 22:06:03]

New patchsets have been uploaded after l-g-t-m from
lukasza@chromium.org,kelvinp@chromium.org

[Jamie, 2015-02-04 22:06:23]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-02-04 22:06:31]

FYI

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/event_listeners.js (right):

https://codereview.chromium.org/900983003/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/event_listeners.js:1: /* Copyright (c) 2015
The Chromium Authors. All rights reserved.
On 2015/02/04 21:13:14, kelvinp wrote:
> Nit: No (C).

Done.

[commit-bot: I haz the power, 2015-02-04 22:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900983003/40001

[commit-bot: I haz the power, 2015-02-04 23:22:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-04 23:24:04]

Patchset 3 (id:??) landed as
https://crrev.com/6af3ad72fa9de2b9249c788da6b54de7e045c796
Cr-Commit-Position: refs/heads/master@{#314674}