Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 900983002: Revert of Mojo+NaCl: Move generated code to mojo/nacl. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo+NaCl: Move generated code to mojo/nacl. (patchset #1 id:1 of https://codereview.chromium.org/896243003/) Reason for revert: Caused build failures on mac bots. Not sure why it failed there but not on the CQ. Original issue's description: > Mojo+NaCl: Move generated code to mojo/nacl. > > This change moves generated code for Mojo support in NaCl from mojo/monacl to > mojo/nacl. This makes the target directory more consistent across GYP and GN > builds. > > An upcoming change for IRT support will generate a header, which will need a > consistent path (relative to include_dirs) across build systems. > > BUG=454466 > > Committed: https://crrev.com/99cdffdb116cf608630600bbbf66a37fcf16695e > Cr-Commit-Position: refs/heads/master@{#314591} TBR=ncbray@chromium.org,jamesr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454466 Committed: https://crrev.com/8ebfc680baa6179dcb6d4bd9438add5f1e16ba3e Cr-Commit-Position: refs/heads/master@{#314597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/mojo_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
Created Revert of Mojo+NaCl: Move generated code to mojo/nacl.
5 years, 10 months ago (2015-02-04 18:53:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900983002/1
5 years, 10 months ago (2015-02-04 18:53:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 18:54:35 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:55:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ebfc680baa6179dcb6d4bd9438add5f1e16ba3e
Cr-Commit-Position: refs/heads/master@{#314597}

Powered by Google App Engine
This is Rietveld 408576698