Initial changelist for the app remoting test driver tool

Initial checkin for the app remoting test driver tool.  The external pieces of the test driver will consist of a common library which will build the dependencies and core helper classes and a minimal version of the tool which will include a minimal number of tests.  An internal version of the tool will include the common library and pull in additional tests from src-internal.

The tool uses the GTest framework and this CL is to set up the foundation
so I can start adding functionality.  I am not hooking it into the public gyp
files yet, that will come in a future change as more changes to the
remoting GYP files are expected.

BUG=

Committed: https://crrev.com/2079b57f0bd295d100e36850956af31c6d52316b
Cr-Commit-Position: refs/heads/master@{#314712}

[joedow, 2015-02-04 18:58:01]

joedow@chromium.org changed reviewers:
+ garykac@chromium.org, jamiewalch@chromium.org, wez@chromium.org

[Jamie, 2015-02-05 00:38:40]

LGTM with nits.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
File remoting/test/app_remoting_test_driver.cc (right):

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:26: // scope fragments are necessary
and will be escaped properly before use.
Optional: I usually put the spaces at the start of lines instead of at the ends.
It makes them stand out more clearly.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:34: // Used to generate an
authorization code request string.
There's no need for this to be declared as a global. You can move it into
GetAuthorizationCodeUri.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:59: const char kAnsiColorReset[] =
"\x1b[0m";
These don't work for all terminal types. You should probably add an option to
disable them.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:94: " remote host connection.\n");
Word-wrap these to 80-characters (or fewer, if you want to make the source code
look neat as well).

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:140:
command_line->AppendSwitchASCII(switches::kTestLauncherRetryLimit, "0");
Blank line here, I think.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:141: // We do not want to run the
tests in parallel and we do not
The word-wrap is a bit funky here.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:146:
command_line->AppendSwitch("single-process-tests");
Maybe add this to the switches namespace for consistency?

[joedow, 2015-02-05 01:19:15]

New patchsets have been uploaded after l-g-t-m from jamiewalch@chromium.org

[joedow, 2015-02-05 01:19:48]

Updated based on Jamie's feedback.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
File remoting/test/app_remoting_test_driver.cc (right):

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:26: // scope fragments are necessary
and will be escaped properly before use.
On 2015/02/05 00:38:40, Jamie wrote:
> Optional: I usually put the spaces at the start of lines instead of at the
ends.
> It makes them stand out more clearly.

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:34: // Used to generate an
authorization code request string.
On 2015/02/05 00:38:40, Jamie wrote:
> There's no need for this to be declared as a global. You can move it into
> GetAuthorizationCodeUri.

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:59: const char kAnsiColorReset[] =
"\x1b[0m";
On 2015/02/05 00:38:40, Jamie wrote:
> These don't work for all terminal types. You should probably add an option to
> disable them.

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:94: " remote host connection.\n");
On 2015/02/05 00:38:40, Jamie wrote:
> Word-wrap these to 80-characters (or fewer, if you want to make the source
code
> look neat as well).

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:140:
command_line->AppendSwitchASCII(switches::kTestLauncherRetryLimit, "0");
On 2015/02/05 00:38:40, Jamie wrote:
> Blank line here, I think.

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:141: // We do not want to run the
tests in parallel and we do not
On 2015/02/05 00:38:40, Jamie wrote:
> The word-wrap is a bit funky here.

Done.

https://codereview.chromium.org/900973002/diff/1/remoting/test/app_remoting_t...
remoting/test/app_remoting_test_driver.cc:146:
command_line->AppendSwitch("single-process-tests");
On 2015/02/05 00:38:40, Jamie wrote:
> Maybe add this to the switches namespace for consistency?

Done.

[joedow, 2015-02-05 01:19:54]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2015-02-05 01:21:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900973002/20001

[commit-bot: I haz the power, 2015-02-05 01:39:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-05 01:41:17]

Patchset 2 (id:??) landed as
https://crrev.com/2079b57f0bd295d100e36850956af31c6d52316b
Cr-Commit-Position: refs/heads/master@{#314712}