Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 900963003: Add DomDistiller.PageDistilledType and update DD.PageDistillableType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index dd6c1a631aa4fe65d5d0198155aaf924971924f6..87283bf99655e3b5936619798df16033791657a0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5435,11 +5435,19 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
-<histogram name="DomDistiller.PageDistillable" enum="BooleanDistillable">
cjhopman 2015/02/04 18:15:16 This histogram previously used UMA_HISTOGRAM_BOOLE
Ilya Sherman 2015/02/04 23:08:44 Yes, that's a valid change. A boolean histogram i
- <owner>yfriedman@chromium.org</owner>
+<histogram name="DomDistiller.PageDistillable" enum="DistillableType">
+ <owner>cjhopman@chromium.org</owner>
<summary>
- Records the number of times a page was loaded for which using DomDistiller
- is possible.
+ Records the &quot;Distillable Type&quot; (not distillable, distillable,
+ mobile-friendly distillable, etc) for each analyzed page.
+ </summary>
+</histogram>
+
+<histogram name="DomDistiller.PageDistilledType" enum="DistillableType">
+ <owner>cjhopman@chromium.org</owner>
+ <summary>
+ Records the &quot;Distillable Type&quot; (distillable, mobile-friendly
+ distillable, etc) for each distilled page.
Ilya Sherman 2015/02/04 23:08:44 It might help to clarify whether "mobile-friendly
cjhopman 2015/02/06 01:43:00 Done.
</summary>
</histogram>
@@ -43492,11 +43500,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="1" label="Did fall back"/>
</enum>
-<enum name="BooleanDistillable" type="int">
- <int value="0" label="Not distillable"/>
- <int value="1" label="Distillable"/>
-</enum>
-
<enum name="BooleanDuplicate" type="int">
<int value="0" label="Not Duplicate"/>
<int value="1" label="Duplicate"/>
@@ -44815,6 +44818,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="3" label="Primary accounts present but different"/>
</enum>
+<enum name="DistillableType" type="int">
+ <int value="0" label="Not distillable"/>
+ <int value="1" label="Distillable"/>
+ <int value="2" label="Mobile-friendly distillable"/>
+</enum>
+
<enum name="DllHash" type="int">
<!-- Generated by chrome_elf/dll_hash/dll_hash_main.cc -->
« no previous file with comments | « tools/metrics/actions/actions.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698