Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 90093002: V8StringResource's v8StringToWebCoreString() should return a StringType (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin
Visibility:
Public.

Description

V8StringResource's v8StringToWebCoreString() should return a StringType V8StringResource's v8StringToWebCoreString() should return a StringType, not a String. This avoids useless conversions from String to AtomicString when StringType is an AtomicString. R=haraken BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/v8/V8StringResource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years ago (2013-11-27 00:48:27 UTC) #1
haraken
LGTM. Nice catch.
7 years ago (2013-11-27 00:49:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90093002/1
7 years ago (2013-11-27 01:08:09 UTC) #3
Inactive
On 2013/11/27 00:49:33, haraken wrote: > LGTM. Nice catch. I hope to make the AtomicString(const ...
7 years ago (2013-11-27 01:09:36 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-27 02:32:39 UTC) #5
Message was sent while issue was closed.
Change committed as 162722

Powered by Google App Engine
This is Rietveld 408576698