Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 900913004: [cast/test] Use AudioConverter in FakeMediaSource to play back 6-channel WEBM's. (Closed)

Created:
5 years, 10 months ago by miu
Modified:
5 years, 10 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cast/test] Use AudioConverter in FakeMediaSource to play back 6-channel WEBM's. Replaces the use of MultiChannelResampler with AudioConverter in FakeMediaSource to allow the cast_sender_app and cast_simulator to re-mix any-number-of-channels audio into the 2-channel audio for Cast sending. Committed: https://crrev.com/267652edbd64fd42e71ed4f9557e0d807518c018 Cr-Commit-Position: refs/heads/master@{#314680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M media/cast/test/fake_media_source.h View 7 chunks +12 lines, -6 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 9 chunks +28 lines, -25 lines 0 comments Download
M media/cast/test/sender.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
hclam: PTAL.
5 years, 10 months ago (2015-02-04 23:01:38 UTC) #2
Alpha Left Google
lgtm
5 years, 10 months ago (2015-02-04 23:07:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900913004/1
5 years, 10 months ago (2015-02-04 23:08:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 23:49:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 23:50:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/267652edbd64fd42e71ed4f9557e0d807518c018
Cr-Commit-Position: refs/heads/master@{#314680}

Powered by Google App Engine
This is Rietveld 408576698