Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 900903002: DevTools: do not use Internals for inspector highlight tests. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
Reviewers:
dgozman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not use Internals for inspector highlight tests. BUG=451004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189531

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2022 lines, -151 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 chunks +10 lines, -13 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-css-shapes-outside-expected.txt View 8 chunks +1241 lines, -55 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll-expected.txt View 3 chunks +306 lines, -16 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node-expected.txt View 2 chunks +61 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scaled.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scaled-expected.txt View 2 chunks +61 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scroll-expected.txt View 3 chunks +122 lines, -12 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node-transformed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight-node-transformed-expected.txt View 2 chunks +61 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-svg-content-inside-iframe-expected.txt View 2 chunks +16 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-svg-root-expected.txt View 2 chunks +61 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-svg-root-zoomed-expected.txt View 2 chunks +61 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pfeldman
5 years, 10 months ago (2015-02-04 14:11:37 UTC) #2
yurys
lgtm https://codereview.chromium.org/900903002/diff/1/LayoutTests/http/tests/inspector/elements-test.js File LayoutTests/http/tests/inspector/elements-test.js (right): https://codereview.chromium.org/900903002/diff/1/LayoutTests/http/tests/inspector/elements-test.js#newcode882 LayoutTests/http/tests/inspector/elements-test.js:882: function report(nodeId, error, result) You can drop nodeId ...
5 years, 10 months ago (2015-02-04 15:00:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900903002/20001
5 years, 10 months ago (2015-02-04 19:42:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:33:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189531

Powered by Google App Engine
This is Rietveld 408576698