Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 90083002: Cast Extensions API: Major namespace and object renaming (Closed)

Created:
7 years ago by Alpha Left Google
Modified:
7 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Cast Extensions API: Major namespace and object renaming There is no functional change in this patch. This change only does renaming. Extensions API namespaces: webrtc.castSendTransport -> cast.streaming.rtpStream webrtc.castUdpTransport -> cast.streaming.udpTransport Class renaming: WebRtcNativeHandler -> CastStreamingNativeHandler CastSendTransport -> CastRtpStream Tests and related files are also renamed to get rid of the webrtc label. BUG=301920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238403

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : merged again #

Patch Set 4 : merged again and again #

Patch Set 5 : fix unit_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -1140 lines) Patch
A + chrome/browser/extensions/cast_streaming_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/extensions/webrtc_cast_apitest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 chunk +96 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/cast_streaming_session.idl View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/common/extensions/api/cast_streaming_udp_transport.idl View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/webrtc_cast_send_transport.idl View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/common/extensions/api/webrtc_cast_udp_transport.idl View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
A + chrome/renderer/extensions/cast_streaming_native_handler.h View 1 2 3 4 chunks +20 lines, -20 lines 0 comments Download
A + chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 3 10 chunks +53 lines, -53 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
D chrome/renderer/extensions/webrtc_native_handler.h View 1 2 3 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/renderer/extensions/webrtc_native_handler.cc View 1 2 3 1 chunk +0 lines, -354 lines 0 comments Download
A + chrome/renderer/media/cast_rtp_stream.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/renderer/media/cast_rtp_stream.cc View 3 chunks +8 lines, -8 lines 0 comments Download
D chrome/renderer/media/cast_send_transport.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/renderer/media/cast_send_transport.cc View 1 chunk +0 lines, -164 lines 0 comments Download
A + chrome/renderer/resources/extensions/cast_streaming_rtp_stream_custom_bindings.js View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_session_custom_bindings.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js View 1 chunk +5 lines, -5 lines 0 comments Download
D chrome/renderer/resources/extensions/webrtc_cast_send_transport_custom_bindings.js View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/renderer/resources/extensions/webrtc_cast_udp_transport_custom_bindings.js View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/cast_streaming/basics.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/cast_streaming/basics.js View 1 chunk +11 lines, -11 lines 0 comments Download
A + chrome/test/data/extensions/api_test/cast_streaming/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webrtc_cast/basics.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrtc_cast/basics.js View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrtc_cast/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Alpha Left Google
7 years ago (2013-11-27 00:48:31 UTC) #1
haibinlu
lgtm
7 years ago (2013-11-27 01:06:13 UTC) #2
Alpha Left Google
+kalman +scherkus
7 years ago (2013-11-27 21:34:11 UTC) #3
scherkus (not reviewing)
lgtm
7 years ago (2013-11-27 22:09:39 UTC) #4
Alpha Left Google
+thakis for owners approval for chrome/renderer/resources/renderer_resources.grd.
7 years ago (2013-11-28 00:17:05 UTC) #5
Nico
lgtm
7 years ago (2013-11-28 00:18:23 UTC) #6
not at google - send to devlin
lgtm
7 years ago (2013-12-02 23:12:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/90083002/60001
7 years ago (2013-12-03 01:56:13 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=197542
7 years ago (2013-12-03 02:22:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/90083002/80001
7 years ago (2013-12-03 05:12:27 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-03 15:45:47 UTC) #11
Message was sent while issue was closed.
Change committed as 238403

Powered by Google App Engine
This is Rietveld 408576698