Add JavaScript Harmony flag to chrome://flags

Add JavaScript Harmony flag to chrome://flags

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115570

[arv (Not doing code reviews), 2011-12-21 01:03:49]

Alex, the wording could use improvements. Suggestions welcome.

[arv (Not doing code reviews), 2011-12-21 18:14:10]

Nico, I was wondering if we should add support for "compound" values? At this
point I feel like it is not necessary and that we could wait until the time
someone needs to pass along another flag to V8.

[Nico, 2011-12-21 18:22:21]

On 2011/12/21 18:14:10, arv wrote:
> Nico, I was wondering if we should add support for "compound" values? At this
> point I feel like it is not necessary and that we could wait until the time
> someone needs to pass along another flag to V8.

The MULTI_VALUE_TYPE stuff could probably be tweaked to support this without too
much effort, right?

[arv (Not doing code reviews), 2011-12-21 18:44:01]

On 2011/12/21 18:22:21, Nico wrote:
> On 2011/12/21 18:14:10, arv wrote:
> > Nico, I was wondering if we should add support for "compound" values? At
this
> > point I feel like it is not necessary and that we could wait until the time
> > someone needs to pass along another flag to V8.
> 
> The MULTI_VALUE_TYPE stuff could probably be tweaked to support this without
too
> much effort, right?

I was thinking more that maybe someone in the future wanted to add
--js-flags="--new-option" and at that point we would have to combine the values
to --js-flags="--new-option --harmony".

[Nico, 2011-12-21 18:47:27]

> I was thinking more that maybe someone in the future wanted to add
> --js-flags="--new-option" and at that point we would have to combine the
values
> to --js-flags="--new-option --harmony".

Ah, I see. A different way to make that work would be to change the option
parser to merge multiple --js-flags options – --jsflags=--new-option
--jsflags=--harmony would pass both flags to v8.

But waiting until that becomes necessary sgtm.

[Nico, 2011-12-21 18:49:29]

Oh, and the change lgtm, too :-)

[arv (Not doing code reviews), 2011-12-21 19:02:05]

Andreas, FYI

[rossberg1, 2011-12-22 09:17:31]

Cool, thanks guys!

[rafaelw, 2011-12-22 17:38:42]

http://codereview.chromium.org/9008031/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9008031/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4991: Enable JavaScript Harmony
Suggest: "Enable Experimental JavaScript"

http://codereview.chromium.org/9008031/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4994: Enable web pages to use experimental
JavaScript features that are planned for future versions of JavaScript.
Suggest "Enable web pages to use experimental JavaScript features." and leave it
at that.

[commit-bot: I haz the power, 2011-12-22 17:45:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/9008031/11001

[commit-bot: I haz the power, 2011-12-22 19:05:49]

Change committed as 115570