Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 9008: Add support for arbitrarily transformed Windows buttons text field... (Closed)

Created:
12 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for arbitrarily transformed Windows buttons text fields, and select boxes (but does not affect scroll bars). I created a helper class, ThemeHelperWin, which automatically wraps the logic necessary to do this. There are three modes: draw the form control normally, draw it at a different size (for scaling, just tell Windows it's a different size and don't transform the graphics coordinates), or arbitrary transforms (where it's drawn to an offscreen buffer and transformed by our graphics layer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4890

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -25 lines) Patch
M webkit/build/port/port.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
A webkit/port/platform/graphics/ThemeHelperWin.h View 1 1 chunk +97 lines, -0 lines 4 comments Download
A webkit/port/platform/graphics/ThemeHelperWin.cpp View 1 1 chunk +133 lines, -0 lines 1 comment Download
M webkit/port/rendering/RenderThemeWin.cpp View 4 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
This is the theme-specific part of my previous graphics patch, updated for the new graphics ...
12 years, 1 month ago (2008-11-01 16:17:31 UTC) #1
M-A Ruel
12 years, 1 month ago (2008-11-03 20:18:46 UTC) #2
lgtm

http://codereview.chromium.org/9008/diff/6/8
File webkit/port/platform/graphics/ThemeHelperWin.cpp (right):

http://codereview.chromium.org/9008/diff/6/8#newcode33
Line 33: static void IntRectToRECT(const IntRect& ir, RECT* r)
I guess we can't use operator RECT() because it's in PLATFORM(WIN) ?

http://codereview.chromium.org/9008/diff/6/7
File webkit/port/platform/graphics/ThemeHelperWin.h (right):

http://codereview.chromium.org/9008/diff/6/7#newcode47
Line 47: // Use the original canvas with no changes. This is the normal mode
.

http://codereview.chromium.org/9008/diff/6/7#newcode54
Line 54: // it. This usually looke better.
look

http://codereview.chromium.org/9008/diff/6/7#newcode59
Line 59: COPY
,

http://codereview.chromium.org/9008/diff/6/7#newcode87
Line 87: // When type_ == COPY, this will be a new surface owned by this class
that
m_type

Powered by Google App Engine
This is Rietveld 408576698