google_apis/gcm/engine/connection_factory_impl.cc - Issue 900793009: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 900793009: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove remnant of change Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_write_to_cache_job.cc ('k') | jingle/glue/proxy_resolving_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index 218f833d7c689a5d53b9306dec97d385ebac88b7..a8ec37fe5604fd0052a318def9afbbbaf2b6ced1 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -7,6 +7,7 @@

#include "base/message_loop/message_loop.h"

#include "base/metrics/histogram.h"

#include "base/metrics/sparse_histogram.h"

+#include "base/profiler/scoped_tracker.h"

#include "google_apis/gcm/engine/connection_handler_impl.h"

#include "google_apis/gcm/monitoring/gcm_stats_recorder.h"

#include "google_apis/gcm/protocol/mcs.pb.h"

@@ -342,6 +343,10 @@ base::TimeTicks ConnectionFactoryImpl::NowTicks() {

}

void ConnectionFactoryImpl::OnConnectDone(int result) {

+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455884 is fixed.

+ tracked_objects::ScopedTracker tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "455884 ConnectionFactoryImpl::OnConnectDone"));

if (result != net::OK) {

// If the connection fails, try another proxy.

result = ReconsiderProxyAfterError(result);