net/http/http_proxy_client_socket_pool.cc - Issue 900793009: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool.cc

Issue 900793009: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « jingle/glue/proxy_resolving_client_socket.cc ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_proxy_client_socket_pool.cc

diff --git a/net/http/http_proxy_client_socket_pool.cc b/net/http/http_proxy_client_socket_pool.cc

index 9c8a531778530c6420f9dcd80be1a612baa1ac0f..b97c957cdc8a65a77ab96a9d10f559f09ceb385b 100644

--- a/net/http/http_proxy_client_socket_pool.cc

+++ b/net/http/http_proxy_client_socket_pool.cc

@@ -128,6 +128,10 @@ void HttpProxyConnectJob::GetAdditionalErrorState(ClientSocketHandle * handle) {

}

void HttpProxyConnectJob::OnIOComplete(int result) {

+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455884 is fixed.

+ tracked_objects::ScopedTracker tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "455884 HttpProxyConnectJob::OnIOComplete"));

int rv = DoLoop(result);

if (rv != ERR_IO_PENDING) {

NotifyProxyDelegateOfCompletion(rv);