jingle/glue/proxy_resolving_client_socket.cc - Issue 900793009: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/glue/proxy_resolving_client_socket.cc

Issue 900793009: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « google_apis/gcm/engine/connection_factory_impl.cc ('k') | net/http/http_proxy_client_socket_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: jingle/glue/proxy_resolving_client_socket.cc

diff --git a/jingle/glue/proxy_resolving_client_socket.cc b/jingle/glue/proxy_resolving_client_socket.cc

index 0b35559d5509cf0975f53565e09f32b385294950..916f4178600117b1252d0564d6a61942b5df0783 100644

--- a/jingle/glue/proxy_resolving_client_socket.cc

+++ b/jingle/glue/proxy_resolving_client_socket.cc

@@ -9,6 +9,7 @@

#include "base/bind_helpers.h"

#include "base/compiler_specific.h"

#include "base/logging.h"

+#include "base/profiler/scoped_tracker.h"

#include "net/base/io_buffer.h"

#include "net/base/load_flags.h"

#include "net/base/net_errors.h"

@@ -214,6 +215,10 @@ void ProxyResolvingClientSocket::ProcessProxyResolveDone(int status) {

}

void ProxyResolvingClientSocket::ProcessConnectDone(int status) {

+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455884 is fixed.

+ tracked_objects::ScopedTracker tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "455884 ProxyResolvingClientSocket::ProcessConnectDone"));

if (status != net::OK) {

// If the connection fails, try another proxy.

status = ReconsiderProxyAfterError(status);