Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 900793008: Update {virtual,override,final} to follow C++11 style in printing. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in printing. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/ff7922e556477cb556e3c858b5273a084e80d953 Cr-Commit-Position: refs/heads/master@{#314957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M printing/backend/print_backend_dummy.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_android.h View 2 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:07:14 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-06 01:35:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900793008/1
5 years, 10 months ago (2015-02-06 01:38:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:37:48 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:39:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff7922e556477cb556e3c858b5273a084e80d953
Cr-Commit-Position: refs/heads/master@{#314957}

Powered by Google App Engine
This is Rietveld 408576698