Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 900793007: chromeos::dbus lint errors. (Closed)

Created:
5 years, 10 months ago by dtapuska
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos::dbus lint errors. Fix lint issues. BUG=453873 Committed: https://crrev.com/1d622f0cb5ef828194a49c377e157710eab03b37 Cr-Commit-Position: refs/heads/master@{#315421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chromeos/dbus/dbus_client_bundle.h View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M dbus/test_service.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dtapuska
5 years, 10 months ago (2015-02-05 19:53:03 UTC) #2
hashimoto
thanks, chromeos/dbus lgtm.
5 years, 10 months ago (2015-02-06 03:20:54 UTC) #4
satorux1
dbus/ lgtm sorry for the delay
5 years, 10 months ago (2015-02-09 22:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900793007/1
5 years, 10 months ago (2015-02-09 22:20:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 22:51:55 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:53:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d622f0cb5ef828194a49c377e157710eab03b37
Cr-Commit-Position: refs/heads/master@{#315421}

Powered by Google App Engine
This is Rietveld 408576698