Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 900793002: ServiceWorker: Support SWRegistration.unregister() in SWGlobalScope [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: ready to review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 3118298353c941e36cefc1a0c056dbef52a4bd25..6a47d5af6cfb6ffa7a8242da82cc69ab296cb1e3 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -47,14 +47,16 @@ class WebDataSource;
class WebServiceWorkerCacheStorage;
class WebServiceWorkerContextProxy;
class WebServiceWorkerNetworkProvider;
+class WebServiceWorkerProvider;
class WebServiceWorkerResponse;
class WebString;
// This interface is implemented by the client. It is supposed to be created
// on the main thread and then passed on to the worker thread.
// by a newly created WorkerGlobalScope. All methods of this class, except
-// for createServiceWorkerNetworkProvider() and workerContextFailedToStart(),
-// are called on the worker thread.
+// for createServiceWorkerNetworkProvider(), createServiceWorkerProvider() and
+// workerContextFailedToStart(), are called on the worker thread.
+//
// FIXME: Split this into EmbeddedWorkerContextClient and
// ServiceWorkerScriptContextClient when we decide to use EmbeddedWorker
// framework for other implementation (like SharedWorker).
@@ -148,6 +150,9 @@ public:
// Ownership of the returned object is transferred to the caller.
virtual WebServiceWorkerNetworkProvider* createServiceWorkerNetworkProvider(WebDataSource*) { return 0; }
+ // Ownership of the returned object is transferred to the caller.
+ virtual WebServiceWorkerProvider* createServiceWorkerProvider() { return 0; }
kinuko 2015/02/05 09:09:29 nit: I think we can now return nullptr (back then
nhiroki 2015/02/05 09:12:42 Done.
+
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientsInfo and WebServiceWorkerError ownerships are
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698