ui/file_manager/file_manager/foreground/js/ui/combobutton.js - Issue 900743002: Move preview panel's components to toolbar and footer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/combobutton.js

Issue 900743002: Move preview panel's components to toolbar and footer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a TODO comment about customized CommandButton. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js ('k') | ui/file_manager/file_manager/foreground/js/ui/commandbutton.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/combobutton.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

index b87d69ac185307eb47da6f019b5ad45a12371453..8a4b72a8f17c005ea2393f28b56fde17e171b3f1 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

@@ -58,23 +58,7 @@ cr.define('cr.ui', function() {

set defaultItem(defaultItem) {

this.defaultItem_ = defaultItem;

this.actionNode_.textContent = defaultItem.label || '';

- if (defaultItem.iconType) {

- this.actionNode_.classList.add('with-icon');

- this.actionNode_.style.backgroundImage = '';

- this.actionNode_.setAttribute('file-type-icon', defaultItem.iconType);

- } else if (defaultItem.iconUrl) {

- this.actionNode_.classList.add('with-icon');

- this.actionNode_.style.backgroundImage =

- 'url(' + defaultItem.iconUrl + ')';

- this.actionNode_.removeAttribute('file-type-icon');

- } else {

- this.actionNode_.classList.remove('with-icon');

- this.actionNode_.style.backgroundImage = '';

- this.actionNode_.removeAttribute('file-type-icon');

- }

/**