Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 900703002: webcrypto: Get task-runner for worker-thread from base::ThreadTaskRunnerHandle (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 10 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webcrypto: Get task-runner for worker-thread from base::ThreadTaskRunnerHandle Both main-thread and worker-threads have their own message-loops. So use base::ThreadTaskRunnerHandle::Get() to get the task-runner in both main and worker threads. BUG=none R=eroman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3a4b2d1ad07c4e79ab2923d6a571846d64f9f1f1

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M content/child/webcrypto/webcrypto_impl.cc View 1 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
5 years, 10 months ago (2015-02-03 23:12:05 UTC) #3
Ryan Sleevi
Eric should review this. When this was written, the Worker wasn't setting the ThreadTTRH, AIUI.
5 years, 10 months ago (2015-02-03 23:13:56 UTC) #5
eroman
LGTM. At that code was first written there was written there wasn't a messageloop for ...
5 years, 10 months ago (2015-02-03 23:55:51 UTC) #6
nasko
On 2015/02/03 23:55:51, eroman wrote: > LGTM. > > At that code was first written ...
5 years, 10 months ago (2015-02-04 00:57:47 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3a4b2d1ad07c4e79ab2923d6a571846d64f9f1f1 Cr-Commit-Position: refs/heads/master@{#314457}
5 years, 10 months ago (2015-02-04 01:13:13 UTC) #8
sadrul
5 years, 10 months ago (2015-02-04 01:13:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
3a4b2d1ad07c4e79ab2923d6a571846d64f9f1f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698