Expose the "automatic downloads" content setting to extensions.

Expose the "automatic downloads" content setting to extensions.

BUG=454800
DIFFBASE=869073006

Committed: https://crrev.com/d28b085cffbf034db5bf1bf1e2666472ac9c6636
Cr-Commit-Position: refs/heads/master@{#314564}

[msramek, 2015-02-03 17:52:39]

Patchset #1 (id:1) has been deleted

[msramek, 2015-02-03 17:57:43]

msramek@chromium.org changed reviewers:
+ kalman@chromium.org, mkwst@chromium.org

[msramek, 2015-02-03 17:57:44]

...and this too.

[not at google - send to devlin, 2015-02-03 18:27:36]

lgtm

[Mike West, 2015-02-03 20:21:53]

LGTM % question.

https://codereview.chromium.org/900663002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/900663002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/content_settings.json:274: "description": "Whether
to allow sites to download multiple files automatically. One of
<br><var>allow</var>: Allow sites to download multiple files
automatically,<br><var>block</var>: Don't allow sites to download multiple files
automatically,<br><var>ask</var>: Ask when a site wants to download files
automatically after the first file. <br>Default is <var>ask</var>.<br>The
primary URL is the URL of the top-level frame. The secondary URL is not used.",
Does 'block' just block downloading multiple files automatically? What's the
behavior for the first file?

[msramek, 2015-02-04 12:17:19]

On 2015/02/03 20:21:53, Mike West wrote:
> LGTM % question.
> 
>
https://codereview.chromium.org/900663002/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/api/content_settings.json (right):
> 
>
https://codereview.chromium.org/900663002/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/content_settings.json:274: "description":
"Whether
> to allow sites to download multiple files automatically. One of
> <br><var>allow</var>: Allow sites to download multiple files
> automatically,<br><var>block</var>: Don't allow sites to download multiple
files
> automatically,<br><var>ask</var>: Ask when a site wants to download files
> automatically after the first file. <br>Default is <var>ask</var>.<br>The
> primary URL is the URL of the top-level frame. The secondary URL is not
used.",
> Does 'block' just block downloading multiple files automatically? What's the
> behavior for the first file?

Yes, the emphasis is on the word "multiple". One file will be downloaded, then a
small notification "download blocked" will appear on the right edge of omnibox
(same UI as "popup blocked").

[msramek, 2015-02-04 14:23:22]

New patchsets have been uploaded after l-g-t-m from mkwst@chromium.org

[msramek, 2015-02-04 14:23:58]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-02-04 14:24:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900663002/40001

[commit-bot: I haz the power, 2015-02-04 15:21:29]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-04 15:23:03]

Patchset 2 (id:??) landed as
https://crrev.com/d28b085cffbf034db5bf1bf1e2666472ac9c6636
Cr-Commit-Position: refs/heads/master@{#314564}