Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 900653003: Avoid empty display item pairs (Closed)

Created:
5 years, 10 months ago by Xianzhu
Modified:
5 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, Dominik Röttsches, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid empty display item pairs Seperated from https://codereview.chromium.org/892293002/ which needs to avoid many empty BeginSubtree/EndSubtree display item pairs. This CL can also avoid other empty pairs, to reduce the size of paint list and unnecessary operations to be replayed. TEST=LayerClipRecorder.Empty R=chrishtr@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189575

Patch Set 1 #

Patch Set 2 : Fix try bot breakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -51 lines) Patch
M Source/core/paint/CompositingRecorder.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 1 2 chunks +29 lines, -4 lines 0 comments Download
M Source/core/paint/LayerPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/paint/ClipDisplayItem.h View 4 chunks +10 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/ClipPathDisplayItem.h View 4 chunks +9 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +15 lines, -10 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItem.h View 1 2 chunks +28 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/graphics/paint/FilterDisplayItem.h View 3 chunks +8 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/FilterDisplayItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/FloatClipDisplayItem.h View 4 chunks +9 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/ScrollDisplayItem.h View 4 chunks +16 lines, -5 lines 0 comments Download
M Source/platform/graphics/paint/Transform3DDisplayItem.h View 4 chunks +10 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/TransformDisplayItem.h View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Xianzhu
5 years, 10 months ago (2015-02-04 18:10:39 UTC) #2
chrishtr
lgtm
5 years, 10 months ago (2015-02-04 18:21:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900653003/1
5 years, 10 months ago (2015-02-04 18:22:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/34857)
5 years, 10 months ago (2015-02-04 18:42:07 UTC) #7
Xianzhu
We can't submit this CL until we make decision about whether to use HashMap<DisplayItemClient, Vector<size_t>> ...
5 years, 10 months ago (2015-02-04 18:52:43 UTC) #8
pdr.
On 2015/02/04 at 18:52:43, wangxianzhu wrote: > We can't submit this CL until we make ...
5 years, 10 months ago (2015-02-04 23:07:55 UTC) #9
Xianzhu
On 2015/02/04 23:07:55, pdr wrote: > On 2015/02/04 at 18:52:43, wangxianzhu wrote: > > We ...
5 years, 10 months ago (2015-02-04 23:13:00 UTC) #10
Xianzhu
We can avoid the display item order implication by the new merge algorithm. Submitting this.
5 years, 10 months ago (2015-02-05 00:25:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900653003/20001
5 years, 10 months ago (2015-02-05 05:25:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/49413)
5 years, 10 months ago (2015-02-05 07:12:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900653003/20001
5 years, 10 months ago (2015-02-05 17:02:03 UTC) #18
Xianzhu
5 years, 10 months ago (2015-02-05 17:03:11 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 189575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698